Change line height of the lg font size to 1.625rem
#14223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Unfortunately this PR has undergone the same fate as your other PR so I'm linking my response here too: #14503 (comment) Here's the copy-pastebale userland implementation of this change for anyone stumbling upon this: @theme {
--font-size-lg--line-height: 1.625rem;
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default line height of the
lgfont size looks a bit large compared to the rest of the line heights. You can see this in these demo's (third paragraph):Also, if you plot the values of the relative line heights, you see the gap between
lgandxl(blue dots 4&5):This is a breaking change, so I changed this in
v4.